Skip to content

rename logging.py so doesn't circ import #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifrit98 merged 6 commits into from
Nov 14, 2023
Merged

rename logging.py so doesn't circ import #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8b1de9c
rename logging.py so doesn't circ import
ifrit98 Nov 2, 2023
14eed02
Merge branch 'staging' into rename-logging
ifrit98 Nov 2, 2023
2d1d717
Merge branch 'staging' into rename-logging
ifrit98 Nov 3, 2023
0c70fa3
Merge branch 'staging' into rename-logging
ifrit98 Nov 7, 2023
1e63328
Merge branch 'staging' into rename-logging
ifrit98 Nov 14, 2023
4fa89b2
Merge branch 'staging' into rename-logging
ifrit98 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bittensor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def debug(on: bool = True):
from .chain_data import *
from .subtensor import subtensor as subtensor
from .cli import cli as cli, COMMANDS as ALL_COMMANDS
from .logging import logging as logging
from .btlogging import logging as logging
Copy link
Contributor

@Eugene-hu Eugene-hu Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this maintains the functionality for bittensor.logging, correct?

Copy link
Contributor Author

@ifrit98 ifrit98 Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, only changes the import. Can still call bt.logging.<>.

It's basically covering the edge case in jupyter notebooks where you're running python from the same directory.

from .metagraph import metagraph as metagraph
from .threadpool import PriorityThreadPoolExecutor as PriorityThreadPoolExecutor

Expand Down
0 bittensor/logging.py → bittensor/btlogging.py
View file
Open in desktop
File renamed without changes.