Replace wildcard imports with specific imports#1724
Merged
ifrit98 merged 7 commits intoopentensor:stagingfrom Mar 21, 2024
Merged
Replace wildcard imports with specific imports#1724ifrit98 merged 7 commits intoopentensor:stagingfrom
ifrit98 merged 7 commits intoopentensor:stagingfrom
Conversation
ifrit98
suggested changes
Feb 28, 2024
Contributor
ifrit98
left a comment
ifrit98
left a comment
There was a problem hiding this comment.
See errors. Must pass all CircleCi tests.
brueningf
force-pushed
the
refactor/wildcard-into-specific-imports
branch
from
2b373e1 to
a9d3c00
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action item 5: Break out wildcard import statements into bespoke imports.