handle req args by parsing and raising#1733
Merged
Conversation
wolfentensor
approved these changes
Mar 11, 2024
wolfentensor
left a comment
wolfentensor
left a comment
There was a problem hiding this comment.
The added code is functionally sound and suited for its purpose. One small comment about the exception type.
| missing_required_args = self.__check_for_missing_required_args(parser, args) | ||
| if missing_required_args: | ||
| # Handle missing required arguments gracefully | ||
| raise ValueError( |
There was a problem hiding this comment.
The proper exception to raise is argparse.ArgumentError:
Contributor
Author
There was a problem hiding this comment.
This will not work here because we don't have access the the arg reference.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.