Logging: Added _primary_loggers#1797
Merged
thealligatorking merged 9 commits intostagingfrom May 1, 2024
Merged
Conversation
sepehr-opentensor
suggested changes
Apr 16, 2024
Contributor
sepehr-opentensor
left a comment
There was a problem hiding this comment.
The enabling/disabling of the primary logger is already handled by the state transition logic, you would really only have to replace self._name with a set of strings, and handle accordingly.
1a09f1f to
a497f65
Compare
c24a45a to
0ebc041
Compare
Contributor
|
Documentation for this? |
Contributor
Author
|
Thanks for pointing this out. I'll add documentation for this functionality and also discuss to get these docs (here) updated as well. |
thealligatorking
approved these changes
May 1, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited:
_primary_loggersreplaced_name_name_primary_loggers