Skip to content

Logging: Added _primary_loggers#1797

Merged
thealligatorking merged 9 commits intostagingfrom
logging/abe/adding-first-party-loggers
May 1, 2024
Merged

Logging: Added _primary_loggers#1797
thealligatorking merged 9 commits intostagingfrom
logging/abe/adding-first-party-loggers

Conversation

@ibraheem-abe
Copy link
Contributor

@ibraheem-abe ibraheem-abe commented Apr 16, 2024

Edited:

  • _primary_loggers replaced _name
  • Usage is updated for _name
  • Methods to add/remove loggers in _primary_loggers

@ibraheem-abe ibraheem-abe marked this pull request as ready for review April 16, 2024 20:33
Copy link
Contributor

@sepehr-opentensor sepehr-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enabling/disabling of the primary logger is already handled by the state transition logic, you would really only have to replace self._name with a set of strings, and handle accordingly.

@ibraheem-abe ibraheem-abe changed the title Logging: Added first_party_loggers Logging: Added _primary_loggers Apr 16, 2024
@ibraheem-abe ibraheem-abe force-pushed the logging/abe/adding-first-party-loggers branch from 1a09f1f to a497f65 Compare April 17, 2024 16:41
@ibraheem-abe ibraheem-abe force-pushed the logging/abe/adding-first-party-loggers branch from c24a45a to 0ebc041 Compare April 17, 2024 20:50
@ifrit98
Copy link
Contributor

ifrit98 commented Apr 22, 2024

Documentation for this?

@ibraheem-abe
Copy link
Contributor Author

Thanks for pointing this out. I'll add documentation for this functionality and also discuss to get these docs (here) updated as well.

@thealligatorking thealligatorking merged commit 5412af0 into staging May 1, 2024
@thealligatorking thealligatorking mentioned this pull request May 17, 2024
@thewhaleking thewhaleking deleted the logging/abe/adding-first-party-loggers branch October 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants