Skip to content

Fix: Wallet overwrite functionality#1802

Merged
thealligatorking merged 4 commits intostagingfrom
bugs/abe/wallet-overwrite
Apr 29, 2024
Merged

Fix: Wallet overwrite functionality#1802
thealligatorking merged 4 commits intostagingfrom
bugs/abe/wallet-overwrite

Conversation

@ibraheem-abe
Copy link
Contributor

Bug: The --overwrite_coldkey was not working as expected when regenerating coldkeys: the user was still prompted to enter y/N to confirm the action

Description:

  • add_argument actions were storing the value False (even if the flag was passed as argument)
  • Fix is propagated to other applicable methods as well.

@ibraheem-abe ibraheem-abe changed the title Bug fix: Wallet overwrite functionality Fix: Wallet overwrite functionality Apr 18, 2024
@thealligatorking
Copy link
Contributor

@ibraheem-opentensor is it possible to include tests for this?

@thealligatorking thealligatorking merged commit affc5bf into staging Apr 29, 2024
@thealligatorking thealligatorking mentioned this pull request Apr 29, 2024
@thewhaleking thewhaleking deleted the bugs/abe/wallet-overwrite branch October 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants