Conversation
2b86049 to
a31da79
Compare
…btensorModule" for the btcli console (logic)
a31da79 to
ba4a700
Compare
Collaborator
Author
Hey man!
I hope these explanations help clarify the rationale behind the changes. I am open to further discussion and am willing to consider any other suggestions you might have for effectively addressing this issue. |
8 tasks
e3a36d3 to
ff9a752
Compare
…ort subtensor module as subtensor_module on bittensor package level
ff9a752 to
6979acf
Compare
ibraheem-abe
approved these changes
May 10, 2024
thewhaleking
approved these changes
May 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to split #1859 into 2 PRs:
Also, I had to rename the
subtensor.pymodule due to a conflict between the class name and the module name in the namespace. This will not affect users and will not impact their experience.