Skip to content

fix: deprecated usage of Balances::transfer method#1886

Merged
thealligatorking merged 1 commit intostagingfrom
fix/deprecated-method-usage
May 15, 2024
Merged

fix: deprecated usage of Balances::transfer method#1886
thealligatorking merged 1 commit intostagingfrom
fix/deprecated-method-usage

Conversation

@orriin
Copy link
Contributor

@orriin orriin commented May 15, 2024

transfer is removed and replaced with transfer_allow_death polkadot-js/apps#9854

@orriin orriin added the bug Something isn't working label May 15, 2024
@orriin orriin changed the base branch from master to staging May 15, 2024 17:08
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps we should be using keep alive

@orriin
Copy link
Contributor Author

orriin commented May 15, 2024

That would prevent sending the entire account bal. If you're sure, can change it :)

@thealligatorking thealligatorking merged commit 636ea67 into staging May 15, 2024
@thealligatorking thealligatorking mentioned this pull request May 17, 2024
@distributedstatemachine distributedstatemachine deleted the fix/deprecated-method-usage branch May 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants