feat: Refactor phase 2 overview cmd & add test cov. Adds factories#1887
Merged
thealligatorking merged 3 commits intostagingfrom May 17, 2024
Merged
feat: Refactor phase 2 overview cmd & add test cov. Adds factories#1887thealligatorking merged 3 commits intostagingfrom
thealligatorking merged 3 commits intostagingfrom
Conversation
thealligatorking
force-pushed
the
tests/gus/overview
branch
from
dd56b4d to
2cd1442
Compare
chore: adds req factory boy
thealligatorking
force-pushed
the
tests/gus/overview
branch
from
a34cc07 to
e5032c9
Compare
ibraheem-abe
approved these changes
May 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors portion of
_runmethod inoverview.pyto better support adding test coverage.Proof
Project ticket link: https://github.com/orgs/opentensor/projects/28?pane=issue&itemId=59022057