Skip to content

Add back compatibility with torch#1904

Merged
thewhaleking merged 20 commits intostagingfrom
feature/add-back-compatibility-with-torch/thewhaleking
May 21, 2024
Merged

Add back compatibility with torch#1904
thewhaleking merged 20 commits intostagingfrom
feature/add-back-compatibility-with-torch/thewhaleking

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented May 20, 2024

Adds back compatibility with torch, invoked by passing the USE_TORCH env var.

Fixes #1897

@thewhaleking thewhaleking requested a review from a team May 21, 2024 17:55
@thewhaleking thewhaleking marked this pull request as ready for review May 21, 2024 17:55
@thealligatorking
Copy link
Contributor

Looks great!

Suggestion: add a file .example.env with USE_TORCH= and add a comment to indicate what have it set to 0 or 1 does.

…ool function rather than selecting individually from the `os.environ` every time.
Copy link
Collaborator

@basfroman basfroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants