Merged
Conversation
orriin
force-pushed
the
ci/e2e-tests
branch
3 times, most recently
from
b517625 to
45c1666
Compare
runs on ubuntu
Contributor
|
@orriin taking a look! |
opendansor
reviewed
May 28, 2024
| strategy: | ||
| matrix: | ||
| rust-branch: | ||
| - nightly-2024-03-05 |
There was a problem hiding this comment.
Will this line need to be updated with new releases?
Contributor
Author
There was a problem hiding this comment.
If the rust version changes, yes
opendansor
approved these changes
May 30, 2024
opendansor
left a comment
opendansor
left a comment
There was a problem hiding this comment.
LGTM, one call out is to either create a PR when/if rust version updates or let us know so we can update the rust version ourselves.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the e2e tests in ci to catch regressions like #1914 before they're merged