support Wallet names with hyphens when passing password through ENV vars#1949
Merged
thealligatorking merged 4 commits intoopentensor:stagingfrom Jul 23, 2024
Conversation
mjurbanski-reef
force-pushed
the
support_hypens_when_passing_cold_pw
branch
from
3484d14 to
5ff7584
Compare
mjurbanski-reef
force-pushed
the
support_hypens_when_passing_cold_pw
branch
from
5ff7584 to
b5b8599
Compare
Contributor
Author
|
anything I can do to move this forward? |
mjurbanski-reef
force-pushed
the
support_hypens_when_passing_cold_pw
branch
from
b5b8599 to
81b6be8
Compare
thealligatorking
approved these changes
Jun 21, 2024
Contributor
Author
|
@gus-opentensor anything stopping this from being merged? |
Contributor
|
@mjurbanski-reef tests, I'll merge once they pass. |
Contributor
Author
|
@gus-opentensor the tests are failing since the exactly tests are failing in staging branch that I just merged into this |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Support Wallet names with hyphens when passing password through ENV vars
Alternate Designs
Another solutions would be to:
Possible Drawbacks
A possible drawback is if someone had multiple wallets which only difference was that one had
-instead of_, but that seems VERY unlikely.Verification Process
Added unittest case + manual testing.
Release Notes
BT_COLD_PW_*env vars now can be used to provide password for wallet names with hyphens (use_in place of-)