Fix return of ip version.#1961
Merged
thealligatorking merged 4 commits intorelease/7.0.1from May 31, 2024
Merged
Conversation
added 4 commits
May 31, 2024 10:55
…' into bugfix/opendansor/fix_ip_version # Conflicts: # tests/unit_tests/test_axon.py
garrett-opentensor
approved these changes
May 31, 2024
thealligatorking
approved these changes
May 31, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Description of the Change
Check for IP version instead of hardcoding ipv4 as the version.
Alternate Designs
Possible Drawbacks
Verification Process
Create tests to assert proper ipv4 and ipv6 addresses are permitted, and invalid ip addresses are rejected.
Release Notes