Dependency cleanup#1967
Merged
thealligatorking merged 4 commits intoopentensor:stagingfrom Jun 3, 2024
Merged
Conversation
thealligatorking
approved these changes
Jun 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
pytest,blackdependencies frombittensorpackage requirements. They are now installed only ifbittensor[dev]extras group is requested.~=version specifier incheck_compatiblity.shDependabot has to be enabled in
https://github.com/opentensor/bittensor/settings/security_analysis(please note config file has to be present in default branch for it to be considered by Dependabot).It is recommended that applications use tools allowing for proper dependency locking e.g. pdm, pip-tools, poetry.
This change is still rather conservative, as it mostly unblocks only
.patchversions to be updated.In some packages with strong semver support (e.g. aiohttp) I opted to constrain only major version already.
In future we should be able to do just
>=MAJOR.MINORfor most package that declare semver use and without known vulnerabilities, but for now I opted for safer route of taking one step at a time.