Enhancement: Detailed nonce information in-case of failures#2050
Merged
ibraheem-abe merged 5 commits intostagingfrom Jun 21, 2024
Merged
Enhancement: Detailed nonce information in-case of failures#2050ibraheem-abe merged 5 commits intostagingfrom
ibraheem-abe merged 5 commits intostagingfrom
Conversation
Contributor
ibraheem-abe
commented
Jun 20, 2024
ibraheem-abe
commented
- Increases level of information logged in-case nonces fail.
- Differentiates between different nonce failure scenarios and logsaccordingly.
- Ensures synapse timeout is calculated in ns
bittensor/axon.py
Outdated
| and synapse.dendrite.nonce <= allowed_window_ns | ||
| ): | ||
| raise Exception("Nonce is too old") | ||
| diff_seconds = ( |
Contributor
There was a problem hiding this comment.
can we move this to a helper method so we can get coverage on it?
thealligatorking
approved these changes
Jun 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.