Merged
Conversation
opendansor
force-pushed
the
feature/opendansor/child_hotkeys
branch
from
35a205b to
d2bc588
Compare
opendansor
commented
Jun 27, 2024
4 tasks
thealligatorking
previously approved these changes
Jul 9, 2024
basfroman
requested changes
Jul 9, 2024
Collaborator
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
There are no questions about implementation. I left a few comments regarding the style and tests.
tests/e2e_tests/subcommands/stake/test_set_revoke_child_hotkeys.py
Outdated
Show resolved
Hide resolved
tests/e2e_tests/subcommands/stake/test_set_revoke_child_hotkeys.py
Outdated
Show resolved
Hide resolved
tests/e2e_tests/subcommands/stake/test_set_revoke_child_hotkeys.py
Outdated
Show resolved
Hide resolved
basfroman
previously approved these changes
Aug 9, 2024
thewhaleking
previously approved these changes
Aug 9, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Overall looks good. There's some nitpicks here and there, but I have to redo this in btcli anyway, so I'll just fix it all there.
thealligatorking
previously approved these changes
Aug 9, 2024
opendansor
dismissed stale reviews from thealligatorking, thewhaleking, and basfroman
via
a18fcd5
added 2 commits
August 9, 2024 10:34
basfroman
previously approved these changes
Aug 9, 2024
basfroman
approved these changes
Aug 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to integrate new extrinsics related to child key management into our Python codebase and add corresponding CLI commands. These extrinsics allow users to set and revoke child keys for hotkeys on specific subnets. This feature enhances the flexibility of our stake delegation system.