test: fix mocksubtensor query previous blocks#2139
Merged
thealligatorking merged 3 commits intoopentensor:stagingfrom Jul 17, 2024
Merged
test: fix mocksubtensor query previous blocks#2139thealligatorking merged 3 commits intoopentensor:stagingfrom
thealligatorking merged 3 commits intoopentensor:stagingfrom
Conversation
Contributor
Author
|
@RomanCh-OT hey, now requested merge to staging |
basfroman
approved these changes
Jul 16, 2024
thealligatorking
approved these changes
Jul 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
There is typo when
MockSubtensor.query_subtensorfunction checks previous blocksself.state.get(block, None) -> state.get(block, None)Description of the Change
Discovered internally
Changed to proper variable name
Added tests
Alternate Designs
N/A
Possible Drawbacks
N/A
Verification Process
Verification Process
This functionality had no tests. All tests are passing
Release Notes