Adds E2E Tests for wallet creation commands#2145
Merged
ibraheem-abe merged 5 commits intostagingfrom Jul 18, 2024
Merged
Conversation
Contributor
ibraheem-abe
commented
Jul 18, 2024
ibraheem-abe
commented
- We are testing these commands
- btcli wallet create
- btcli wallet new_coldkey
- btcli wallet new_hotkey
- btcli wallet list
- In each test, we verify the wallet is displayed along with the key in correct format through the cli
- We also test the physical existence of wallets in the system (including coldkeys and hotkeys)
basfroman
approved these changes
Jul 18, 2024
Collaborator
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
Looks pretty well
Just left couple of comments
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.