Adds E2E test for wallet regenerations + fixes input bug for regen hotkey#2149
Merged
ibraheem-abe merged 4 commits intostagingfrom Jul 24, 2024
Merged
Adds E2E test for wallet regenerations + fixes input bug for regen hotkey#2149ibraheem-abe merged 4 commits intostagingfrom
ibraheem-abe merged 4 commits intostagingfrom
Conversation
ibraheem-abe
changed the title
basfroman
approved these changes
Jul 22, 2024
Collaborator
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
just left a few style related comments
| if isinstance(mnemonic, str): | ||
| mnemonic = mnemonic.split() | ||
| elif isinstance(mnemonic, list) and len(mnemonic) == 1: | ||
| mnemonic = mnemonic[0].split() |
Collaborator
There was a problem hiding this comment.
For future review of the code, it would be useful to have a comment describing what mnemonic[0] is and why we are using this particular index.
Contributor
Author
There was a problem hiding this comment.
Hey!
So if we pass the mnemonics encapsulated as a string like:
btcli w regen_coldkey "word word word word......"
The cli doesn't register it at the moment- it actually gets parsed as a list of 1 element which is what we are checking here and then extracting it
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are E2E testing these commands
To test regeneration, we compare the modification timestamps of the file before and after regenerating.
This PR also fixes a bug when inputting the mnemonics as a string using the btcli when regenerating hotkeys. Similar bug for coldkeys was fixed in link