Skip to content

Bringing btsdk up-to-date with staging branch.#2210

Merged
basfroman merged 49 commits intobtsdkfrom
feat/roman/staging-into-btsdk
Aug 7, 2024
Merged

Bringing btsdk up-to-date with staging branch.#2210
basfroman merged 49 commits intobtsdkfrom
feat/roman/staging-into-btsdk

Conversation

@basfroman
Copy link
Collaborator

ibraheem-abe and others added 30 commits July 19, 2024 10:20
…napse

Revert "fix streaming synapse regression"
Bumps [black](https://github.com/psf/black) from 23.7.0 to 24.3.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@23.7.0...24.3.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
…black-24.3.0

Bump black from 23.7.0 to 24.3.0 in /requirements
- add stacklevel=2 so that the filename of the originating call is
  logged (requires Python >= 3.8)
- move *args before prefix and suffix kwargs so regular logging calls
  using args, such as in retry, still work as intended

To elaborate on the last point, retry does the following:

    logger.warning('%s, retrying in %s seconds...', e, _delay)

and the args e and _delay would land on kwargs prefix and suffix without
this patch.

Any code relying on prefix and suffix also being positional arguments,
is now broken.

Note that logger.exception() calls through to logger.error() without
compensating for this additional internal call when determining the
calling file, on CPython < 3.11. This code works around this issue.
In case prefix and suffix are not used, messages are still prefixed and
suffixed with " - ".

This patch addresses that and only injects separators between non-empty
strings.
Add a unit test for:
- correct filename in loglines
- prefix= and suffix= kwargs
- format string functionality
@basfroman basfroman self-assigned this Aug 7, 2024
@thewhaleking thewhaleking changed the base branch from btsdk to feat/roman/btsdk-structure-part-3 August 7, 2024 18:35
Base automatically changed from feat/roman/btsdk-structure-part-3 to btsdk August 7, 2024 20:35
@basfroman basfroman requested a review from a team August 7, 2024 20:43
@basfroman basfroman mentioned this pull request Aug 7, 2024
8 tasks
@basfroman basfroman merged commit ef5634d into btsdk Aug 7, 2024
@basfroman basfroman deleted the feat/roman/staging-into-btsdk branch August 7, 2024 22:53
@ibraheem-abe ibraheem-abe mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants