Child hotkeys handle excess normalization#2229
Merged
opendansor merged 2 commits intostagingfrom Aug 13, 2024
Merged
Conversation
added 2 commits
August 13, 2024 12:01
In staking.py, introduced the floor function for normalized proportions and added logic to handle excess sums. Updated formatting.py to use floor for float-to-u64 conversion, ensuring values stay within bounds.
basfroman
approved these changes
Aug 13, 2024
Comment on lines
+664
to
+666
| normalized_children[0] = ( | ||
| normalized_children[0][0] - (sum_norm - (u64_max - 1)), | ||
| normalized_children[0][1], |
Collaborator
There was a problem hiding this comment.
It would be useful to understand what such indexes mean. Pls add a comment.
Author
There was a problem hiding this comment.
There is a comment on line 658.
It adjusts the first child +- 10 to make sure we dont go over u64 max.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In staking.py, introduced the floor function for normalized proportions and added logic to handle excess sums. Updated formatting.py to use floor for float-to-u64 conversion, ensuring values stay within bounds.