Skip to content

Don't use astype for torch.Tensor#2242

Merged
thewhaleking merged 6 commits intomasterfrom
fix/thewhaleking/incompatible-tensor-attributes
Aug 30, 2024
Merged

Don't use astype for torch.Tensor#2242
thewhaleking merged 6 commits intomasterfrom
fix/thewhaleking/incompatible-tensor-attributes

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Aug 16, 2024

Only apply .astype to the np version in Metagraph._process_weights_and_bonds. Added test.
CC: @mvds00

@thewhaleking thewhaleking requested a review from a team August 16, 2024 11:52
@thewhaleking thewhaleking requested a review from a team August 17, 2024 05:57
@thewhaleking thewhaleking merged commit 71b51b2 into master Aug 30, 2024
@thewhaleking thewhaleking deleted the fix/thewhaleking/incompatible-tensor-attributes branch August 30, 2024 14:16
ibraheem-abe pushed a commit that referenced this pull request Sep 4, 2024
* Broke apart the logic of use_torch and not _process_weights_and_bonds to more clearly read it. Only apply .astype to the np version.

* Add test for weights and bonds using torch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants