Skip to content

feat: return error message instead of raising exception#2244

Merged
thealligatorking merged 2 commits intostagingfrom
feat/gus/update-err-msg-pw
Aug 17, 2024
Merged

feat: return error message instead of raising exception#2244
thealligatorking merged 2 commits intostagingfrom
feat/gus/update-err-msg-pw

Conversation

@thealligatorking
Copy link
Contributor

Overview

  • Previously we would raise an exception and stdout the whole stack trace, this update makes enables a terse error messages.

Ex:

image

@thealligatorking thealligatorking changed the title feat: return error message instead raising exception feat: return error message instead of raising exception Aug 16, 2024
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the instances here where we also unlock the hotkey, do we want to include those in the try block?

@ibraheem-abe
Copy link
Contributor

In the instances here where we also unlock the hotkey, do we want to include those in the try block?

Interesting thought - but confirming if we actually unlock the hotkey currently. afaik, hotkey is without password in our current setup

Copy link
Contributor

@ibraheem-abe ibraheem-abe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think we dont password protect our hotkeys but we can confirm that

@thealligatorking thealligatorking merged commit 6dbc1f1 into staging Aug 17, 2024
@thewhaleking thewhaleking deleted the feat/gus/update-err-msg-pw branch August 17, 2024 08:38
@ibraheem-abe ibraheem-abe mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants