feat: return error message instead of raising exception#2244
Merged
thealligatorking merged 2 commits intostagingfrom Aug 17, 2024
Merged
feat: return error message instead of raising exception#2244thealligatorking merged 2 commits intostagingfrom
thealligatorking merged 2 commits intostagingfrom
Conversation
Contributor
thewhaleking
left a comment
There was a problem hiding this comment.
In the instances here where we also unlock the hotkey, do we want to include those in the try block?
Contributor
Interesting thought - but confirming if we actually unlock the hotkey currently. afaik, hotkey is without password in our current setup |
ibraheem-abe
approved these changes
Aug 16, 2024
Contributor
ibraheem-abe
left a comment
There was a problem hiding this comment.
LGTM.
I think we dont password protect our hotkeys but we can confirm that
opendansor
approved these changes
Aug 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Ex: