Merged
Conversation
added 14 commits
August 20, 2024 12:44
basfroman
previously approved these changes
Aug 28, 2024
Collaborator
basfroman
left a comment
basfroman
left a comment
There was a problem hiding this comment.
LGTM
Left unblocking comments
|
|
||
| @staticmethod | ||
| def _run(cli: "bittensor.cli", subtensor: "bittensor.subtensor"): | ||
| console = Console() |
Collaborator
There was a problem hiding this comment.
should we use bittensor.__console__ instead of Console() to be more consistent?
Author
There was a problem hiding this comment.
For these commands, (that use this function) its mainly rich that gets used.
thealligatorking
previously approved these changes
Aug 28, 2024
opendansor
dismissed stale reviews from thealligatorking and basfroman
via
4f70ce4
basfroman
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child hotkey refactor