BTSDK: Move do* methods to related extrinsic#2286
Merged
Conversation
added 7 commits
September 4, 2024 12:11
…xtrinsics/set_weights.py).
…xtrinsics/transfer.py). + ruff
…xtrinsics/serving.py)
…xtrinsics/prometheus.py)
added 2 commits
September 6, 2024 13:33
…rscored-methods-to-extrinsics
basfroman
changed the title
do* methods to related extrinsic
thewhaleking
requested changes
Sep 9, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Only blocker is the docstring update. Others are just questions/tips.
| # DEALINGS IN THE SOFTWARE. | ||
|
|
||
| from typing import Union, TYPE_CHECKING | ||
| from typing import Dict, Tuple, Optional, Union, TYPE_CHECKING |
Contributor
There was a problem hiding this comment.
You don't need Dict or Tuple.
Collaborator
Author
There was a problem hiding this comment.
I need this because of the linter doesn't want to see dict and tuple instead of Dict and Tuple as type annotation. It's complaints.
tests/e2e_tests/test_incentive.py
Outdated
| import pytest | ||
|
|
||
| import bittensor | ||
| # import bittensor |
Contributor
There was a problem hiding this comment.
Can this line just be entirely removed?
Collaborator
Author
There was a problem hiding this comment.
deferentially. good catch!
| @@ -37,6 +105,7 @@ def commit_weights_extrinsic( | |||
| """ | |||
| Commits a hash of the neuron's weights to the Bittensor blockchain using the provided wallet. | |||
| This function is a wrapper around the `_do_commit_weights` method, handling user prompts and error messages. | |||
…try" has incompatible type "LoggingMachine"; expected "Logger | None" [arg-type]`
thewhaleking
approved these changes
Sep 9, 2024
basfroman
deleted the
feat/roman/move-underscored-methods-to-extrinsics
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bittensor.utils.networking.ensure_connectedlogic and description