Conversation
thewhaleking
requested changes
Sep 6, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Shouldn't we throw an Exception?
Collaborator
Author
I don't think so. Just warning |
Contributor
Doesn't that just pass the buck down the line, and will bring a new exception when a request is attempted on a closed connection? |
Collaborator
Author
No, if the connection data was passed correctly, then even with a missing connection, the reconnection logic will create a new connection and set the timeout again. Otherwise, the user will receive a warning again. |
garrett-opentensor
approved these changes
Sep 6, 2024
thewhaleking
approved these changes
Sep 6, 2024
basfroman
deleted the
fix/roman/removed-exit-sys-call-for-ConnectionRefusedError-in-_get_substrate
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.