Merged
Conversation
added 16 commits
October 17, 2024 14:22
…doesn't brake logic
thewhaleking
requested changes
Oct 29, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Few initial change requests and questions. Most of the questions are more high-level so I want to make sure we're all on the same page first.
Comment on lines
+516
to
+519
| with console.status( | ||
| f":satellite: Checking Account on [bold]subnet:{netuid}[/bold]...", | ||
| spinner="aesthetic", | ||
| ) as status: |
Contributor
There was a problem hiding this comment.
Do we want this stuff in the SDK?
Comment on lines
+585
to
+587
| err_console.print( | ||
| f":white_heavy_check_mark: [green]Already registered on netuid:{netuid}[/green]" | ||
| ) |
Contributor
There was a problem hiding this comment.
Shouldn't these be do with btlogging?
bittensor/core/settings.py
Outdated
Comment on lines
+56
to
+83
| bt_err_console = Console(stderr=True) | ||
| bt_verbose_console = Console(quiet=True) | ||
|
|
||
|
|
||
| def print_console(message: str, colour: str, title: str, console: Console): | ||
| console.print( | ||
| f"[bold {colour}][{title}]:[/bold {colour}] [{colour}]{message}[/{colour}]\n" | ||
| ) | ||
|
|
||
|
|
||
| def print_verbose(message: str, status=None): | ||
| """Print verbose messages while temporarily pausing the status spinner.""" | ||
| if status: | ||
| status.stop() | ||
| print_console(message, "green", "Verbose", bt_verbose_console) | ||
| status.start() | ||
| else: | ||
| print_console(message, "green", "Verbose", bt_verbose_console) | ||
|
|
||
|
|
||
| def print_error(message: str, status=None): | ||
| """Print error messages while temporarily pausing the status spinner.""" | ||
| if status: | ||
| status.stop() | ||
| print_console(message, "red", "Error", bt_err_console) | ||
| status.start() | ||
| else: | ||
| print_console(message, "red", "Error", bt_err_console) |
Contributor
There was a problem hiding this comment.
Does this make sense in an SDK?
Collaborator
Author
There was a problem hiding this comment.
After some thought, I applied all the comments.
NOTE: Do not update the branch until the testnet is updated from devnet
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
thewhaleking
approved these changes
Nov 4, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Approved pending merge conflict
added 5 commits
November 4, 2024 09:24
…ubtensor-stage-one # Conflicts: # bittensor/core/extrinsics/prometheus.py
…ubtensor-stage-one # Conflicts: # bittensor/core/extrinsics/set_weights.py # bittensor/core/extrinsics/transfer.py # requirements/prod.txt
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included changes:
All extrinsics added to AsyncSubtensor as methods