Handle new PasswordError from btwallet#2406
Merged
thewhaleking merged 16 commits intostagingfrom Nov 13, 2024
Merged
Conversation
basfroman
requested changes
Nov 12, 2024
basfroman
requested changes
Nov 12, 2024
basfroman
previously approved these changes
Nov 13, 2024
camfairchild
previously approved these changes
Nov 13, 2024
Co-authored-by: Cameron Fairchild <cameron@opentensor.dev>
thewhaleking
dismissed stale reviews from camfairchild and basfroman
via
e93cac6
camfairchild
approved these changes
Nov 13, 2024
basfroman
approved these changes
Nov 13, 2024
basfroman
added a commit
that referenced
this pull request
Nov 13, 2024
* Handles new PasswordError from btwallet. * Ruff, docstrings. * Fixes hotkey unlock rather than coldkey * Added unit test. * Added unit test. Add integration test. * Removed coldkeypub * Opinions. * More tests * grammar * Update test_utils.py * bump up btwallet version * fix wording * fix wording * Update tests/unit_tests/utils/test_utils.py Co-authored-by: Cameron Fairchild <cameron@opentensor.dev> --------- Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com> Co-authored-by: Roman <roman@opentensor.dev> Co-authored-by: Cameron Fairchild <cameron@opentensor.dev>
basfroman
added a commit
that referenced
this pull request
Nov 13, 2024
* added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * ruff * move out `_decode_hex_identity_dict` from inner function * added tests until `AsyncSubtensor.query_identity` * added tests until `AsyncSubtensor.get_hotkey_owner` * Handle new PasswordError from btwallet (#2406) * Handles new PasswordError from btwallet. * Ruff, docstrings. * Fixes hotkey unlock rather than coldkey * Added unit test. * Added unit test. Add integration test. * Removed coldkeypub * Opinions. * More tests * grammar * Update test_utils.py * bump up btwallet version * fix wording * fix wording * Update tests/unit_tests/utils/test_utils.py Co-authored-by: Cameron Fairchild <cameron@opentensor.dev> --------- Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com> Co-authored-by: Roman <roman@opentensor.dev> Co-authored-by: Cameron Fairchild <cameron@opentensor.dev> * [Tests] AsyncSubtensor (Part 4) (#2410) * added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * ruff * move out `_decode_hex_identity_dict` from inner function * added tests until `AsyncSubtensor.query_identity` * added tests from `AsyncSubtensor.get_netuids_for_hotkey` until `AsyncSubtensor.neurons_lite` * fix * ruff --------- Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com> Co-authored-by: Cameron Fairchild <cameron@opentensor.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2405
Do not merge til new bt-wallet is added
Integration test will be expanded before merging as well (after bt-wallet release)