Merged
Conversation
thewhaleking
force-pushed
the
feat/thewhaleking/integration-tests
branch
2 times, most recently
from
fa41f4f to
af0e605
Compare
thewhaleking
force-pushed
the
feat/thewhaleking/integration-tests
branch
from
af0e605 to
0e98e68
Compare
thewhaleking
requested review from
basfroman and
ibraheem-abe
and removed request for
basfroman
This was referenced Nov 21, 2024
…integration-tests # Conflicts: # bittensor/core/subtensor.py # tests/integration_tests/test_subtensor_integration.py
…rather than websocket.WebSocket now that we've converted.
basfroman
reviewed
Nov 23, 2024
basfroman
previously approved these changes
Nov 23, 2024
ibraheem-abe
previously approved these changes
Nov 25, 2024
Contributor
ibraheem-abe
left a comment
ibraheem-abe
left a comment
There was a problem hiding this comment.
All tests passing 👍
thewhaleking
dismissed stale reviews from ibraheem-abe and basfroman
via
7850686
ibraheem-abe
approved these changes
Nov 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests, initial batch