Conversation
ibraheem-abe
previously approved these changes
Nov 19, 2024
ibraheem-abe
approved these changes
Nov 20, 2024
Contributor
ibraheem-abe
left a comment
ibraheem-abe
left a comment
There was a problem hiding this comment.
Few suggestions, overall lgtm
thewhaleking
force-pushed
the
fix/roman/reconnection
branch
from
9ac7d6c to
c3468ab
Compare
Comment on lines
+186
to
+189
| old_level = logging.get_level() | ||
| logging.set_info() | ||
| logging.success("Connection successfully restored!") | ||
| logging.setLevel(old_level) |
Contributor
There was a problem hiding this comment.
I don't understand why we need this.
Collaborator
Author
There was a problem hiding this comment.
yeah, after #2446 we don't need this logic.
after we merge 2446 I gonna apply btlogging.console everywhere we need it (like in this case).
thewhaleking
approved these changes
Nov 20, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.