Skip to content

Fixes logic for checking block_since_last_update #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibraheem-abe merged 1 commit into from
Nov 25, 2024
Merged

Fixes logic for checking block_since_last_update #2473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions tests/e2e_tests/test_root_set_weights.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,11 @@ async def test_root_reg_hyperparams(local_chain):
alice_wallet.hotkey.ss58_address, netuid
)

# Fetch the block since last update, so we can compare later
initial_block = subtensor.blocks_since_last_update(
# Fetch the block since last update for the neuron
block_since_update = subtensor.blocks_since_last_update(
netuid=netuid, uid=alice_uid_sn_1
)
assert block_since_update is not None

# Verify subnet <netuid> created successfully
assert local_chain.query(
Expand Down Expand Up @@ -191,10 +192,6 @@ async def test_root_reg_hyperparams(local_chain):
return_error_message=True,
)

updated_block = subtensor.blocks_since_last_update(netuid=netuid, uid=0)
# Ensure updates are reflected through incremental block numbers
assert updated_block > initial_block

# TODO: Implement
# This registers neuron using pow but it doesn't work on fast-blocks - we get stale pow
# pow_registration = subtensor.register(bob_wallet, netuid=1)
Expand Down