[SDK] Add commit reveal v3 logic (python part only)#2484
Merged
ibraheem-abe merged 41 commits intostagingfrom Dec 13, 2024
Merged
[SDK] Add commit reveal v3 logic (python part only)#2484ibraheem-abe merged 41 commits intostagingfrom
commit reveal v3 logic (python part only)#2484ibraheem-abe merged 41 commits intostagingfrom
Conversation
added 7 commits
November 25, 2024 20:25
add improved reveal-round params
* Added e2e test for crv3 + enhancements * Fixes type * Ruff * Fixes return type * Renames method
thewhaleking
requested changes
Dec 12, 2024
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Minor changes needed
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
thewhaleking
previously approved these changes
Dec 12, 2024
garrett-opentensor
approved these changes
Dec 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a next step, I need to implement rust FFI with pyo3 to provide it as python package bittensor-commit-revealAfter rust FFI ready, function
bittensor.core.extrinsics.commit_reveal.get_encrypted_commitwill be replaced to the imported one.AC: