Skip to content

Fix logging config parsing #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibraheem-abe merged 5 commits into from
Nov 30, 2024
Merged

Fix logging config parsing #2500

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8b500d
Fixed logging configs not getting parsed when passing whole bittensor…
ibraheem-abe Nov 28, 2024
04a8714
Handles defaultmunch behaviour
ibraheem-abe Nov 28, 2024
35fd676
Improvements
ibraheem-abe Nov 29, 2024
b70c2cd
Removes unused import
ibraheem-abe Nov 29, 2024
263218a
Completes comment
ibraheem-abe Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions bittensor/utils/btlogging/loggingmachine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

import argparse
import atexit
import copy
import logging as stdlogging
import multiprocessing as mp
import os
Expand Down Expand Up @@ -182,7 +181,8 @@ def _extract_logging_config(self, config: "Config") -> dict:
Returns:
(dict): btlogging's config from Bittensor config or Bittensor config.
"""
if hasattr(config, "logging"):
# This is to handle nature of DefaultMunch
if getattr(config, "logging", None):
return config.logging
else:
return config
Expand Down Expand Up @@ -213,14 +213,14 @@ def set_config(self, config: "Config"):
Args:
config (bittensor.core.config.Config): Bittensor config instance.
"""
self._config = config
if config.logging_dir and config.record_log:
self._config = self._extract_logging_config(config)
if self._config.logging_dir and self._config.record_log:
expanded_dir = os.path.expanduser(config.logging_dir)
logfile = os.path.abspath(os.path.join(expanded_dir, DEFAULT_LOG_FILE_NAME))
self._enable_file_logging(logfile)
if config.trace:
if self._config.trace:
self.enable_trace()
elif config.debug:
elif self._config.debug:
self.enable_debug()

def _create_and_start_listener(self, handlers):
Expand Down Expand Up @@ -618,7 +618,7 @@ def __call__(
logging_dir: str = None,
):
if config is not None:
cfg = copy.deepcopy(config)
cfg = self._extract_logging_config(config)
if debug is not None:
cfg.debug = debug
elif trace is not None:
Expand Down