Skip to content

Exit set_weights on success#2511

Merged
thewhaleking merged 1 commit intostagingfrom
fix/thewhaleking/set-weights-exit-on-success
Dec 3, 2024
Merged

Exit set_weights on success#2511
thewhaleking merged 1 commit intostagingfrom
fix/thewhaleking/set-weights-exit-on-success

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Dec 3, 2024

Previously Subtensor.set_weights did not exit on success — only exiting when max_retries is hit or blocks are reached.

@thewhaleking thewhaleking requested a review from a team December 3, 2024 11:45
@thewhaleking thewhaleking merged commit 91211da into staging Dec 3, 2024
@thewhaleking thewhaleking deleted the fix/thewhaleking/set-weights-exit-on-success branch December 3, 2024 14:45
@ibraheem-abe ibraheem-abe mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@camfairchild camfairchild camfairchild approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thewhaleking @camfairchild