Skip to content

test_dendrite test clean up #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewhaleking merged 1 commit into from
Dec 4, 2024
Merged

test_dendrite test clean up #2512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 21 additions & 28 deletions tests/unit_tests/test_dendrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,7 @@ def setup_dendrite():
# Assuming bittensor.Wallet() returns a wallet object
user_wallet = get_mock_wallet()
dendrite_obj = Dendrite(user_wallet)
return dendrite_obj


@pytest.fixture
def dendrite_obj(setup_dendrite):
return setup_dendrite
yield dendrite_obj


@pytest.fixture
Expand All @@ -82,37 +77,35 @@ def setup_axon():


def test_init(setup_dendrite):
dendrite_obj = setup_dendrite
assert isinstance(dendrite_obj, Dendrite)
assert dendrite_obj.keypair == setup_dendrite.keypair
assert isinstance(setup_dendrite, Dendrite)


def test_str(dendrite_obj):
expected_string = f"dendrite({dendrite_obj.keypair.ss58_address})"
assert str(dendrite_obj) == expected_string
def test_str(setup_dendrite):
expected_string = f"dendrite({setup_dendrite.keypair.ss58_address})"
assert str(setup_dendrite) == expected_string


def test_repr(dendrite_obj):
expected_string = f"dendrite({dendrite_obj.keypair.ss58_address})"
assert repr(dendrite_obj) == expected_string
def test_repr(setup_dendrite):
expected_string = f"dendrite({setup_dendrite.keypair.ss58_address})"
assert repr(setup_dendrite) == expected_string


def test_close(dendrite_obj, setup_axon):
def test_close(setup_dendrite, setup_axon):
axon = setup_axon
# Query the axon to open a session
dendrite_obj.query(axon, SynapseDummy(input=1))
setup_dendrite.query(axon, SynapseDummy(input=1))
# Session should be automatically closed after query
assert dendrite_obj._session is None
assert setup_dendrite._session is None


@pytest.mark.asyncio
async def test_aclose(dendrite_obj, setup_axon):
async def test_aclose(setup_dendrite, setup_axon):
axon = setup_axon
# Use context manager to open an async session
async with dendrite_obj:
await dendrite_obj([axon], SynapseDummy(input=1), deserialize=False)
async with setup_dendrite:
await setup_dendrite([axon], SynapseDummy(input=1), deserialize=False)
# Close should automatically be called on the session after context manager scope
assert dendrite_obj._session is None
assert setup_dendrite._session is None


class AsyncMock(Mock):
Expand Down Expand Up @@ -298,7 +291,7 @@ def test_terminal_info_error_cases(

@pytest.mark.asyncio
async def test_dendrite__call__success_response(
axon_info, dendrite_obj, mock_aio_response
axon_info, setup_dendrite, mock_aio_response
):
input_synapse = SynapseDummy(input=1)
expected_synapse = SynapseDummy(
Expand All @@ -318,7 +311,7 @@ async def test_dendrite__call__success_response(
f"http://127.0.0.1:666/SynapseDummy",
body=expected_synapse.json(),
)
synapse = await dendrite_obj.call(axon_info, synapse=input_synapse)
synapse = await setup_dendrite.call(axon_info, synapse=input_synapse)

assert synapse.input == 1
assert synapse.output == 2
Expand All @@ -329,7 +322,7 @@ async def test_dendrite__call__success_response(

@pytest.mark.asyncio
async def test_dendrite__call__handles_http_error_response(
axon_info, dendrite_obj, mock_aio_response
axon_info, setup_dendrite, mock_aio_response
):
status_code = 414
message = "Custom Error"
Expand All @@ -339,7 +332,7 @@ async def test_dendrite__call__handles_http_error_response(
status=status_code,
payload={"message": message},
)
synapse = await dendrite_obj.call(axon_info, synapse=SynapseDummy(input=1))
synapse = await setup_dendrite.call(axon_info, synapse=SynapseDummy(input=1))

assert synapse.axon.status_code == synapse.dendrite.status_code == status_code
assert synapse.axon.status_message == synapse.dendrite.status_message == message
Expand Down Expand Up @@ -400,17 +393,17 @@ def test_process_error_message(
synapse_ip,
synapse_port,
request_name,
setup_dendrite,
):
# Arrange
dendrite = Dendrite()
synapse = Mock()

synapse.timeout = synapse_timeout
synapse.axon.ip = synapse_ip
synapse.axon.port = synapse_port

# Act
result = dendrite.process_error_message(synapse, request_name, exception)
result = setup_dendrite.process_error_message(synapse, request_name, exception)

# Assert
assert result.dendrite.status_code == expected_status_code
Expand Down