AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate)#2526
Merged
basfroman merged 223 commits intostaging-pre-merge-new-asyncfrom Jan 11, 2025
Merged
AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate)#2526basfroman merged 223 commits intostaging-pre-merge-new-asyncfrom
basfroman merged 223 commits intostaging-pre-merge-new-asyncfrom
Conversation
thewhaleking
changed the title
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
2 times, most recently
from
d81be92 to
a35276a
Compare
thewhaleking
commented
Dec 10, 2024
This was referenced Dec 10, 2024
thewhaleking
changed the title
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
3 times, most recently
from
e5c8451 to
8383fce
Compare
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
2 times, most recently
from
914b86a to
59778da
Compare
1 task
…om the substrate-interface with bt-decode
Uses the new async_substrate_interface lib
…rate' into feat/thewhaleking/new-sync-substrate # Conflicts: # requirements/prod.txt
basfroman
changed the base branch from
staging
to
staging-pre-merge-new-async
basfroman
approved these changes
Jan 11, 2025
basfroman
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging, this needs to be thoroughly manually tested.
Changes Subtensor (not AsyncSubtensor) to use AsyncSubstrateInterface through a wrapper. Adjusts the rest of Subtensor to handle this (including tests). Also improves the handling of reconnection in AsyncSubstrateInterface, which directly improves the sync version of it.
Removes all our
ensure_connectedwrappers, because we are now able to do the reconnection logic directly in the (Async)SubstrateInterfaceTODO:
Important to know for users of release:
SubstrateRequestException) will need to be caught frombittensor.core.errorsrather thansubstrateinterface.exceptions.SubstrateInterfacehas changed.