Skip to content

Updates tests for btwallet 3.0.0#2540

Merged
ibraheem-abe merged 5 commits intostagingfrom
tests/update-tests-btwallet3
Jan 17, 2025
Merged

Updates tests for btwallet 3.0.0#2540
ibraheem-abe merged 5 commits intostagingfrom
tests/update-tests-btwallet3

Conversation

@ibraheem-abe
Copy link
Contributor

@ibraheem-abe ibraheem-abe commented Dec 14, 2024

  • Updates tests for btwallet 3.0
  • Bumps wallet version
  • Need to figure out if we can simulate TTY reads for password input testing. It works well but if we can add a test for it, it will be nice. Currently using env_vars to check unlocking.

Ref: https://docs.rs/rpassword/latest/rpassword/#functions

@ibraheem-abe ibraheem-abe marked this pull request as ready for review January 8, 2025 00:13
basfroman
basfroman previously approved these changes Jan 8, 2025
@ibraheem-abe ibraheem-abe merged commit 86f9b4d into staging Jan 17, 2025
30 checks passed
@ibraheem-abe ibraheem-abe deleted the tests/update-tests-btwallet3 branch January 17, 2025 01:21
@ibraheem-abe ibraheem-abe mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants