test(2472): offline unittests#2596
Merged
zyzniewski-reef merged 5 commits intostagingfrom Feb 18, 2025
Merged
Conversation
zyzniewski-reef
requested review from
basfroman,
ibraheem-abe and
thewhaleking
zyzniewski-reef
force-pushed
the
fix/2472-offline_unittests
branch
from
fbdd99f to
1f27022
Compare
zyzniewski-reef
force-pushed
the
fix/2472-offline_unittests
branch
from
b486ca3 to
79c85d4
Compare
thewhaleking
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#2472
Description of the Change
networking.get_external_ipSubstrateInterfaceto use mocked websocketsClientConnectClientConnectas a dependency to SubtensorAlternate Designs
Not extracting common fixtures and just copy & past fixes.
Possible Drawbacks
We're not testing
networking.get_external_ipconnectivity with all hardcoded known addresses.Verification Process
Running unittests online & offline.
Release Notes