test: use asynccontextmanager for FastAPI lifespan#2597
Merged
thewhaleking merged 12 commits intostagingfrom Feb 18, 2025
Merged
test: use asynccontextmanager for FastAPI lifespan#2597thewhaleking merged 12 commits intostagingfrom
thewhaleking merged 12 commits intostagingfrom
Conversation
zyzniewski-reef
force-pushed
the
test/use_asynccontextmanager_for_fastapi_lifespan
branch
2 times, most recently
from
840ee2e to
ddb9829
Compare
basfroman
previously approved these changes
Jan 22, 2025
zyzniewski-reef
force-pushed
the
test/use_asynccontextmanager_for_fastapi_lifespan
branch
from
ddb9829 to
321d359
Compare
thewhaleking
requested changes
Jan 23, 2025
thewhaleking
previously approved these changes
Feb 3, 2025
thewhaleking
previously approved these changes
Feb 3, 2025
ibraheem-abe
previously approved these changes
Feb 3, 2025
thewhaleking
dismissed stale reviews from ibraheem-abe and themself
via
c6d26d7
thewhaleking
approved these changes
Feb 18, 2025
thewhaleking
deleted the
test/use_asynccontextmanager_for_fastapi_lifespan
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
test_threaded_fastapi not synchronizing correctly with FastAPIThreadedServer thread.
Description of the Change
Async generator function lifespans are deprecated, use an @contextlib.asynccontextmanager function instead