fix integration metagraph test#2613
Merged
basfroman merged 5 commits intostaging-pre-merge-port-raofrom Jan 30, 2025
Merged
Conversation
added 2 commits
January 29, 2025 20:00
thewhaleking
requested changes
Jan 30, 2025
bittensor/core/async_subtensor.py
Outdated
|
|
||
| all_delegates_details = {} | ||
| async for ss58_address, identity in identities_info: | ||
| for ss58_address, identity in identities_info: |
Collaborator
Author
There was a problem hiding this comment.
Exactly so. In this code, the use of async loop is redundant which complicates testing and that's it. Inside this loop there are sync function calls.
Contributor
There was a problem hiding this comment.
Take this snippet for example:
async def main():
async with AsyncSubtensor("test") as subtensor:
print(await subtensor.get_delegate_identities())It won't work, because AsyncQueryMapResult has no __next__ method.
(with the current async-substrate-interface
Collaborator
Author
There was a problem hiding this comment.
Ah, yeah. This is AsyncQueryMapResult with async iterator instead of QueryMapResult with sync one.
Make sense. I checked all calls inside for loop, but not the iterated object. Let's bring it back and replace mocked object with AsyncMock
thewhaleking
approved these changes
Jan 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we need to improve this test. but it's fine for now