Use async-substrate-interface for runtime decoding#2618
Merged
thewhaleking merged 20 commits intostaging-pre-merge-new-asyncfrom Feb 3, 2025
Merged
Use async-substrate-interface for runtime decoding#2618thewhaleking merged 20 commits intostaging-pre-merge-new-asyncfrom
thewhaleking merged 20 commits intostaging-pre-merge-new-asyncfrom
Conversation
c60148c to
04955f6
Compare
Contributor
thewhaleking
left a comment
There was a problem hiding this comment.
Soft approval. Will look more in-depth over the weekend.
bt_decode in SDK. Getitng decoded data from async-substrait-interface package.
bt_decode in SDK. Getitng decoded data from async-substrait-interface package.
Contributor
|
For the chain_data classes, should we consider using the I ask because this may help to alleviate issues relating to changing data structures from the chain. However, it's not so simple, because how would we handle items that aren't plain data, such as Balances that need to be fixed before setting? |
basfroman
approved these changes
Feb 3, 2025
ibraheem-abe
reviewed
Feb 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires: