Skip to content

Use async-substrate-interface for runtime decoding#2618

Merged
thewhaleking merged 20 commits intostaging-pre-merge-new-asyncfrom
feat/zyzniewski/use_bt_decode
Feb 3, 2025
Merged

Use async-substrate-interface for runtime decoding#2618
thewhaleking merged 20 commits intostaging-pre-merge-new-asyncfrom
feat/zyzniewski/use_bt_decode

Conversation

@zyzniewski-reef
Copy link
Contributor

@zyzniewski-reef zyzniewski-reef commented Jan 30, 2025

@zyzniewski-reef zyzniewski-reef marked this pull request as draft January 30, 2025 21:57
@zyzniewski-reef zyzniewski-reef force-pushed the feat/zyzniewski/use_bt_decode branch from c60148c to 04955f6 Compare January 31, 2025 18:48
@zyzniewski-reef zyzniewski-reef marked this pull request as ready for review January 31, 2025 18:49
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft approval. Will look more in-depth over the weekend.

@basfroman basfroman changed the title Use bt_decode Get rid bt_decode in SDK. Getitng decoded data from async-substrait-interface package. Feb 1, 2025
@basfroman basfroman added do not merge rao RAO related changes. labels Feb 1, 2025
@thewhaleking thewhaleking changed the title Get rid bt_decode in SDK. Getitng decoded data from async-substrait-interface package. Use async-substrate-interface for runtime decoding Feb 1, 2025
@thewhaleking
Copy link
Contributor

thewhaleking commented Feb 3, 2025

For the chain_data classes, should we consider using the get method rather than __get__?

I ask because this may help to alleviate issues relating to changing data structures from the chain. However, it's not so simple, because how would we handle items that aren't plain data, such as Balances that need to be fixed before setting?

@thewhaleking thewhaleking merged commit d70fa03 into staging-pre-merge-new-async Feb 3, 2025
15 checks passed
@thewhaleking thewhaleking deleted the feat/zyzniewski/use_bt_decode branch February 3, 2025 22:31
@ibraheem-abe ibraheem-abe mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge rao RAO related changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants