Skip to content

Adds get_all_commitments and fixes commitment tests and query_map#2644

Merged
ibraheem-abe merged 2 commits intostaging-pre-merge-new-asyncfrom
async/thewhaleking/fix-commitments
Feb 7, 2025
Merged

Adds get_all_commitments and fixes commitment tests and query_map#2644
ibraheem-abe merged 2 commits intostaging-pre-merge-new-asyncfrom
async/thewhaleking/fix-commitments

Conversation

@thewhaleking
Copy link
Contributor

  • Fixes Subtensor.query_map and AsyncSubtensor.query_map
  • Adds ability to get all commitments from a given netuid
  • Fixes tests relating to get_commitment and query_map

@thewhaleking thewhaleking requested a review from a team February 7, 2025 14:23
Copy link
Collaborator

@basfroman basfroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty good, but pls fix tests

@ibraheem-abe
Copy link
Contributor

Merging this in - lets update the integration tests in our branch

@ibraheem-abe ibraheem-abe merged commit 4e61074 into staging-pre-merge-new-async Feb 7, 2025
11 of 15 checks passed
@ibraheem-abe ibraheem-abe deleted the async/thewhaleking/fix-commitments branch February 7, 2025 21:05
This was referenced Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants