Skip to content

Feat: set_delegate_take#2731

Merged
zyzniewski-reef merged 21 commits intostagingfrom
feat/zyzniewski/set_delegate_take
Mar 13, 2025
Merged

Feat: set_delegate_take#2731
zyzniewski-reef merged 21 commits intostagingfrom
feat/zyzniewski/set_delegate_take

Conversation

@zyzniewski-reef
Copy link
Contributor

@zyzniewski-reef zyzniewski-reef requested a review from a team March 7, 2025 12:30
block_hash: Optional[str] = None,
reuse_block: bool = False,
) -> Optional[float]:
) -> float:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_delegate_take always returns value even for non-existing hotkey (InitialDefaultDelegateTake)

zyzniewski-reef and others added 2 commits March 7, 2025 17:49
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@zyzniewski-reef zyzniewski-reef requested review from a team and thewhaleking March 10, 2025 08:41
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions. Overall looks good, but I think we should adjust that the new methods should take raise_error bool args, with default False to keep consistency with the rest of the codebase. Otherwise you have people writing different styles of code to handle two types of situations (and the unlock keys should be done in the same way, though they should also take a raise_error arg). I agree with your thinking that we should raise errors rather than return success bool for an SDK, but we must also keep consistency in code style throughout. When we make a plan for 10.0, we'll add deprecation warnings to all raise_error=False situations.

@zyzniewski-reef zyzniewski-reef requested a review from a team March 12, 2025 18:23
@zyzniewski-reef zyzniewski-reef merged commit ffa3f1e into staging Mar 13, 2025
37 checks passed
@zyzniewski-reef zyzniewski-reef deleted the feat/zyzniewski/set_delegate_take branch March 13, 2025 18:27
This was referenced Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants