Conversation
| block_hash: Optional[str] = None, | ||
| reuse_block: bool = False, | ||
| ) -> Optional[float]: | ||
| ) -> float: |
There was a problem hiding this comment.
get_delegate_take always returns value even for non-existing hotkey (InitialDefaultDelegateTake)
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
thewhaleking
left a comment
There was a problem hiding this comment.
Few suggestions. Overall looks good, but I think we should adjust that the new methods should take raise_error bool args, with default False to keep consistency with the rest of the codebase. Otherwise you have people writing different styles of code to handle two types of situations (and the unlock keys should be done in the same way, though they should also take a raise_error arg). I agree with your thinking that we should raise errors rather than return success bool for an SDK, but we must also keep consistency in code style throughout. When we make a plan for 10.0, we'll add deprecation warnings to all raise_error=False situations.
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
…e' into feat/zyzniewski/set_delegate_take
#2716