Skip to content

[WIP] add rate limit set for network register#2740

Closed
open-junius wants to merge 2 commits intostagingfrom
fix-no-sudo-set
Closed

[WIP] add rate limit set for network register#2740
open-junius wants to merge 2 commits intostagingfrom
fix-no-sudo-set

Conversation

@open-junius
Copy link
Contributor

Welcome!
To fix the failed network registration because of network rate limit.

@open-junius open-junius changed the title add rate limit set for network register [WIP] add rate limit set for network register Mar 12, 2025
@zyzniewski-reef
Copy link
Contributor

Hi!
Can you please provide an exact error are you trying to fix?
E2E tests are running in isolation from each other (local chain spines up for each one) and you shouldn't get any network rate limits at this point.
Maybe are you looking for a set_weights_set_rate_limit fix?

@open-junius
Copy link
Contributor Author

Hi! Can you please provide an exact error are you trying to fix? E2E tests are running in isolation from each other (local chain spines up for each one) and you shouldn't get any network rate limits at this point. Maybe are you looking for a set_weights_set_rate_limit fix?

Hi, I can see some e2e test cases failed in subtensor side. I think there some updated in the subtensor side, for example, some hyperparameter set origin is root, but it is subnet owner or root before. I created a PR also in https://github.com/opentensor/subtensor/pull/1401/files#diff-8b1545deb9940274a9080bda2bbe37d1a3f4410c8774efac6152e13764dd9e94R45 to check if I can fix all failed cases.
I will update the comments after fix them all.
For network rate limit, we need to set it. according to the configuration, we can't register a network until block 7200.
I will double check if we really should set it for each case.

@zyzniewski-reef
Copy link
Contributor

zyzniewski-reef commented Mar 13, 2025

I think there some updated in the subtensor side, for example, some hyperparameter set origin is root, but it is subnet owner or root before.

This exact problem (AssertionError: Failed to set weights_rate_limit) has been fixed with #2739

Can you please try running your E2E tests again on updated staging?

@open-junius
Copy link
Contributor Author

I think there some updated in the subtensor side, for example, some hyperparameter set origin is root, but it is subnet owner or root before.

This exact problem (AssertionError: Failed to set weights_rate_limit) has been fixed with #2739

Can you please try running your E2E tests again on updated staging?

Sure, let me rebase and try again. thanks

@zyzniewski-reef
Copy link
Contributor

For network rate limit, we need to set it. according to the configuration, we can't register a network until block 7200.

In our E2E tests we're using localnet.sh script which builds subtensor-node with pow-faucet feature which should bring NetworkRateLimit to 0

@zyzniewski-reef zyzniewski-reef added the invalid This doesn't seem right label Mar 13, 2025
@open-junius
Copy link
Contributor Author

For network rate limit, we need to set it. according to the configuration, we can't register a network until block 7200.

In our E2E tests we're using localnet.sh script which builds subtensor-node with pow-faucet feature which should bring NetworkRateLimit to 0

Let me check my local script parameter, I may exclude it for some tests. sorry about it.

@open-junius open-junius self-assigned this Mar 13, 2025
@open-junius
Copy link
Contributor Author

close it since the fix already included in the latest commit of staging

@open-junius open-junius deleted the fix-no-sudo-set branch March 13, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants