Merged
Conversation
basfroman
changed the title
ibraheem-abe
previously approved these changes
Mar 17, 2025
thewhaleking
requested changes
Mar 17, 2025
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Overall LGTM. Just a few changes.
tests/e2e_tests/conftest.py
Outdated
| if sys.platform.startswith("linux"): | ||
| docker_commend = ( | ||
| "Install docker with command " | ||
| "[blue]sudo apt-get update && sudo apt-get install docker.io -y[/blue]" |
Contributor
There was a problem hiding this comment.
This only works for apt-based distros. May want to adjust the wording here.
tests/e2e_tests/conftest.py
Outdated
| if not result.stdout.strip(): | ||
| raise RuntimeError("Docker container failed to start.") | ||
|
|
||
| yield SubstrateInterface(url="ws://127.0.0.1:9944") |
Contributor
There was a problem hiding this comment.
we should .close() this in the finally block
added 2 commits
March 17, 2025 11:45
added 2 commits
March 17, 2025 11:48
thewhaleking
previously approved these changes
Mar 17, 2025
thewhaleking
approved these changes
Mar 17, 2025
ibraheem-abe
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until opentensor/subtensor#1415 merged
Massive e2e test improvement
Tests are run on the basis of the docker image
ghcr.io/opentensor/subtensor-localnet:latest