Fix E2E test_incentive by waiting till start of the very next epoch#2746
Merged
ibraheem-abe merged 2 commits intostagingfrom Mar 17, 2025
Merged
Fix E2E test_incentive by waiting till start of the very next epoch#2746ibraheem-abe merged 2 commits intostagingfrom
ibraheem-abe merged 2 commits intostagingfrom
Conversation
zyzniewski-reef
changed the title
ibraheem-abe
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run test_incentive around 20 times on CI/CD and it seems stable now.
I think the problem was down to time.sleep(5) in Validator which is bigger than epoch's duration for fast-blocks (10 blocks * 0.25s) so it's prone to skip (oversleep) one.
Now E2E waits for the first successful set_weights and checks results immediately