Improve logic in Balance magic methods#2764
Merged
Conversation
# Conflicts: # tests/e2e_tests/utils/chain_interactions.py
thewhaleking
reviewed
Apr 7, 2025
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
A bit confused here because it seems it still does the arithmetic, but just displays a warning. Is this what we want?
Collaborator
Author
Exactly. Right now we can't brake users' scripts. That would cause hate. We decided to display a warning. Perhaps by version 10 we'll decide to change this logic. But we have to let users know that the operation is being performed with an error if the units don't match. |
thewhaleking
previously approved these changes
Apr 7, 2025
ibraheem-abe
approved these changes
Apr 7, 2025
thewhaleking
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.