Dendrite: log ClientOSError as Debug#2770
Merged
thewhaleking merged 7 commits intoopentensor:stagingfrom Apr 17, 2025
Merged
Conversation
Collaborator
|
Hey @Thykof, please rebase this PR to |
Contributor
|
Hi @Thykof , |
Contributor
Author
Hi, yes we are seeing a lot of and they are treating as DEBUG but sometimes we have similar network error treated as ERROR: I couldn't find time to have a look at the unit test yet. |
Collaborator
Don't worry. There is no rush. |
thewhaleking
approved these changes
Apr 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Adding, Changing, or Removing a Feature
Description of the Change
This change if on the filter of the error in the dendrite. The goal is to log with level debug a larger scope of errors.
Currently
aiohttp.ClientConnectorErroris log as error, but someaiohttp.ClientOSErrorare sometimes raised.aiohttp.ClientOSErroris mother ofaiohttp.ClientConnectorError.I propose to log as level debug all
aiohttp.ClientOSError.Alternate Designs
Possible Drawbacks
We might miss some error that should bring attention.
Verification Process
Release Notes
Dendrite: log ClientOSError as Debug