Skip to content

Fix for flaky behavior of test_incentive, test_commit_weights and test_set_weights #2795

Merged
basfroman merged 125 commits intostagingfrom
fix/roman/hope-incentive-passed-always
Apr 11, 2025
Merged

Fix for flaky behavior of test_incentive, test_commit_weights and test_set_weights #2795
basfroman merged 125 commits intostagingfrom
fix/roman/hope-incentive-passed-always

Conversation

@basfroman
Copy link
Collaborator

@basfroman basfroman commented Apr 7, 2025

Includes:

  • fixed a few small bugs.
  • added skipping the test if it flaky (we run 5 versions of tests on different supported python versions)

AC:

Observation:

  • workflows/jobs launched using Python 3.13 take 1.5-2 times longer to complete
  • subnet-template required some changes (weights were set frequently and without a period (for fast blocks))
  • the chain takes longer to release data if running at low power
  • ubuntu-latest GH runner is really faster than custom SubtenroCI one
  • during local testing, reduce docker resources to a minimum. This will show more resource-sensitive operations.
  • error code 1012 means the transaction with the same data can get in pool black-list. see this post

Created issues/tickets:

ibraheem-abe
ibraheem-abe previously approved these changes Apr 7, 2025
@basfroman basfroman changed the title Fix for test_incentive Fix for test_incentive, test_commit_weights and test_set_weights Apr 7, 2025
@basfroman basfroman changed the title Fix for test_incentive, test_commit_weights and test_set_weights Fix for flaky behavior of test_incentive, test_commit_weights and test_set_weights Apr 7, 2025
thewhaleking
thewhaleking previously approved these changes Apr 10, 2025
thewhaleking
thewhaleking previously approved these changes Apr 10, 2025
@basfroman basfroman merged commit 39288bb into staging Apr 11, 2025
125 checks passed
@basfroman basfroman deleted the fix/roman/hope-incentive-passed-always branch April 11, 2025 00:03
This was referenced Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix flaky tests

4 participants