Skip to content

Fix AxonInfo initialization in get_mock_neuron function#2803

Merged
thewhaleking merged 10 commits intoopentensor:stagingfrom
VolodymyrBg:bg
Apr 17, 2025
Merged

Fix AxonInfo initialization in get_mock_neuron function#2803
thewhaleking merged 10 commits intoopentensor:stagingfrom
VolodymyrBg:bg

Conversation

@VolodymyrBg
Copy link
Contributor

Updated the AxonInfo initialization in the get_mock_neuron function to use the correct parameters according to the AxonInfo class definition. Specifically:

  • Removed incorrect 'block' parameter
  • Added required 'hotkey' and 'coldkey' parameters
  • Changed 'ip' parameter from integer 0 to string "0.0.0.0"
    This fixes the TODO comment that indicated the AxonInfo implementation wasn't working correctly.

@basfroman
Copy link
Collaborator

@VolodymyrBg, please rebase this PR to staging branch instead of master one.
Thank you!

@VolodymyrBg
Copy link
Contributor Author

@VolodymyrBg, please rebase this PR to staging branch instead of master one. Thank you!

did I do it correctly?

@basfroman basfroman changed the base branch from master to staging April 9, 2025 18:48
@basfroman
Copy link
Collaborator

@VolodymyrBg, please rebase this PR to staging branch instead of master one. Thank you!

did I do it correctly?

no worries. I did it.

@VolodymyrBg
Copy link
Contributor Author

@VolodymyrBg, please rebase this PR to staging branch instead of master one. Thank you!

did I do it correctly?

no worries. I did it.

Thanks))

Comment on lines +115 to +116
hotkey="some_hotkey",
coldkey="some_coldkey",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use here get_mock_hotkey and get_mock_coldkey methods instead of some_hotkey and some_coldkey strings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

Sorry for confusing you. I ment get_mock_hotkey and get_mock_coldkey methods such we have in that module. Not just a string.

@VolodymyrBg VolodymyrBg requested a review from basfroman April 11, 2025 19:52
@thewhaleking thewhaleking merged commit 0c75b51 into opentensor:staging Apr 17, 2025
121 of 123 checks passed
@ibraheem-abe ibraheem-abe mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants