Skip to content

Fix and improve e2e tests after start call new limit in subtensor#2830

Merged
basfroman merged 30 commits intostagingfrom
fix/roman/e2e-relared-with-start-call
Apr 17, 2025
Merged

Fix and improve e2e tests after start call new limit in subtensor#2830
basfroman merged 30 commits intostagingfrom
fix/roman/e2e-relared-with-start-call

Conversation

@basfroman
Copy link
Collaborator

@basfroman basfroman commented Apr 16, 2025

Includes:

  • main issue with start_call related fixes
  • updated set-output in GH workflow
  • added e2e tests retry mechanism with 2 attempts for each test

@basfroman basfroman requested a review from a team April 16, 2025 23:02
@basfroman basfroman self-assigned this Apr 16, 2025
@basfroman basfroman added bug Something isn't working feature new feature added testing labels Apr 16, 2025
)

subtensor.wait_for_block(subtensor.block + 20)
status, message = subtensor.start_call(dave_wallet, dave_subnet_netuid, True, True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make a test helper for register subnet and start call

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make a test helper for register subnet and start call

We've discussed it already. I want to add this feature in an elegant way later

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's added

basfroman and others added 4 commits April 17, 2025 10:10
Co-authored-by: Cameron Fairchild <cameron@opentensor.dev>
Co-authored-by: Cameron Fairchild <cameron@opentensor.dev>
@basfroman basfroman requested review from a team and camfairchild April 17, 2025 18:53
@basfroman basfroman merged commit 53762f7 into staging Apr 17, 2025
125 checks passed
@basfroman basfroman deleted the fix/roman/e2e-relared-with-start-call branch April 17, 2025 19:15
@ibraheem-abe ibraheem-abe mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature new feature added testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants